Constructing an Amount from an Amount?
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 58
- Forks
- 12
- Avg merge
- 2h 35m
- Merged PRs (30d)
- 2
Description
In the comments for #49 the question of whether we should be able to construct an Amount from an Amount arose, which seems worth asking outside of the context of that issue.
So: bracketing off the questions related to using with to increase the number of significant digits that were raised in that issue, should we treat:
let a = new Amount(1.234, { significantDigits: 4 });
let b = new Amount(a, { significantDigits: 2 });
as equivalent to
let b = new Amount(1.234, {significantDigits: 4}).with({ significantDigits: 2 })
and, more generally, should we allow Amounts as arguments to the Amount constructor?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the discussion in issue #49 and the examples in this issue. Determine whether the Amount constructor should accept an existing Amount and how significantDigits should behave; the work is complete only once the project’s API decision is documented and any corresponding implementation or tests are identified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100