tc39 / tc39/ecmarkup

skip `del` elements when matching productions

Open
#450 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
245
Forks
80
Avg merge
10h 46m
Merged PRs (30d)
2

Description

https://github.com/tc39/ecmarkup/pull/449 makes the logic for matching productions at least work in the presence of <ins> and <del>, but really you don't want to include <del>'d things in the matching logic. For example, if you define Foo : Bar, then Foo : Bar <del>Baz</del> should match that. Conversely, if you define Foo: Bar Baz, then Foo : Bar <del>Baz</del> should not match that.

The matching logic should skip anything within a <del> tag.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests; start by reviewing the production-matching logic and the changes in PR #449. Add coverage for productions with deleted elements so deleted content is ignored when matching, including both matching and non-matching examples.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.