Text-adjacent HTML comments cause markup generation to fail
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 245
- Forks
- 80
- Avg merge
- 10h 46m
- Merged PRs (30d)
- 2
Description
Identified in tc39/ecma262#1589.
Normal case:
<p>
Greetings.
</p>
<!-- comment -->
<p>The value *42* is my favorite.</p>
→
<p>
Greetings.
</p>
<!-- comment -->
<p>The value <emu-val>42</emu-val> is my favorite.</p>
Problem case:
<p>
Greetings.
<!-- comment -->
</p>
<p>The value *42* is my favorite.</p>
→
<p>
Greetings.
<!-- comment -->
</p>
<p>The value *42* is my favorite.</p>
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the normal and problem cases from the issue, then trace the markup-generation entry point that handles text adjacent to HTML comments. The fix is done when the problem case preserves the comment and generates the expected emphasis markup without regressing the normal case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100