taye / taye/interact.js

'tap' events are firing on 'doubletap' and 'hold' V1.10.11

Open
#964 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
12.9k
Forks
804
PR merge metrics
No merged PRs in 30d

Description

When we double click, then tap will also fire (with event.double is false).
The same is true for 'hold'

If I understood this comment https://github.com/taye/interact.js/issues/155#issuecomment-71202352 correctly, then it is expected, that (on double clikc) the tap event is also fired with event.double=false - but this is not the case (event.double=true)

Here is a full stackblitz example

Expected behavior

On double-click the tap event should fire and have event.double=true.
On hold the tap event should not fire.

Actual behavior

On double-click the tap event fires and has event.double=false.
On hold the 'hold' event fires, and then the tap event fires.

System configuration

1.10.11:
Google Chrome Version 100.0.4896.88:
Windows 10:

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked StackBlitz reproduction, specifically src/app/app.component.ts, and reproduce the double-click and hold interactions on interact.js 1.10.11. Compare the tap, doubletap, and hold events with the expected behavior: double-click tap should report event.double=true, while hold should not emit tap.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, javascript, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.