tauri-apps / tauri-apps/plugins-workspace

[notifications]: Plugin causes crash on Windows 7

Open
#1,967 2 comments 2 reactions 0 assignees View on GitHub
platform: windows plugin: notification type: bug
Dominant language
Rust
Stars
1.8k
Forks
602
Avg merge
4d 14h
Merged PRs (30d)
9

Description

As Windows 7 is still used in large organisations, despite being EOL since Jan 2023. Our app is occasionally ran on such systems and it works good when the notifications plugin is not installed.

It's not a critical feature to have the notifications on neither Windows 7, nor versions after, but still - we're willing to put time into this.

The issue is that `notify-rust` crate uses `winrt-notification`, which at some point was forked by @lucasfernog (kudos for doing it, btw!) as of this issue: https://github.com/hoodie/notify-rust/issues/148 and PR: https://github.com/hoodie/notify-rust/pull/149

I'm submitting the issue on the Tauri plugins workspace, because it actually affects Tauri users and the documentation on the website is misleading:
https://v2.tauri.app/distribute/windows-installer/#supporting-windows-7

When enabling the plugin (with or without the "windows7-compat" feature), the app crashes on Windows 7 before launching with the error explained in https://github.com/tauri-apps/tauri/issues/727

I suppose the app can't even be built on Windows 7 due to the dependencies `winrt-notification` is using, namely:
https://github.com/tauri-apps/winrt-notification/blob/dev/src/lib.rs#L34C1-L41C3

So question is - what should be the angle to attack this? And is the issue caused by `winrt-notification` or up/downstream?

As I said - we're willing to put the work for doing the hard work - we need guidance which is the way to approach it.

Kudos everyone from the Tauri team - as always - you've built something amazing! Keep it up!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.