`taskgraph build-image` fails for images that use $DOCKER_IMAGE_PARENT

Open
#582 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
38/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
docker, python, rust
Domain
build-system, cli, devops

Research direction

Start at the taskgraph build-image CLI and compare its docker build path with the build-image tasks. Read taskcluster/docker/image_builder, including the kaniko and custom Rust handling of $DOCKER_IMAGE_PARENT. Done means the CLI follows the image_builder behavior closely enough to build images using that parent syntax.

Written by the indexing model from the issue text.

Description

The root issue here is that the build-image tasks and taskgraph build-image, build images two separate ways. The former uses the image_builder image (which is defined in Gecko and imo should live in this repo.. but that's another story). This image_builder image uses kaniko and a bit of custom Rust code, and is where the $DOCKER_IMAGE_PARENT variable is processed. The latter simply shells out to docker build. So obviously, that's not going to recognize our custom parent syntax.

Instead, taskgraph build-image should also use the image_builder image and try to replicate what the build-image tasks do as much as possible.

Dominant language
Python
Stars
26
Forks
55
Avg merge
2d 6m
Merged PRs (30d)
15

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from taskcluster/taskgraph

All issues in taskcluster/taskgraph

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.