support more than strings and lists in `from-dep`'s `with-attributes`

Open
#341 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
devops

Research direction

Start by locating the from-dep handling for with-attributes and the existing matching logic for direct values and lists. Confirm how true and other basic types are currently treated, then make direct values and list members consistent; done means both examples match as intended and the relevant behavior is covered by tests.

Written by the indexing model from the issue text.

Description

Right now, from-dep supports matching arbitrary values if they are part of a list of values, but only matching strings when directly defined. For example, you can do this:

from-deps:
  with-attributes:
    foo: [true]

But not:

from-deps:
  with-attributes:
    foo: true

We should probably be more lenient about the types of values we allow outside of the list, or more restrictive about what's allowed in the list. (I suggest that all basic types should be allowed in both places.)

Dominant language
Python
Stars
26
Forks
55
Avg merge
2d 6m
Merged PRs (30d)
15

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from taskcluster/taskgraph

All issues in taskcluster/taskgraph

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.