Hook last fire expiration issue

Open
#5,839 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
database

Research direction

Start by locating the hooks_last_fires data model and the code that currently expires records after more than one year. Check which consumers rely on older records and clarify the proposed 1000-record limit. Done means retention is bounded without breaking those consumers, with the issue's open question resolved.

Written by the indexing model from the issue text.

Description

Ah, right -- IIRC we thought about deleting if there are more than N for a hook, but that's a more complicated query. That might be worth considering anyway? In another PR of course :)

Originally posted by @djmitche in https://github.com/taskcluster/taskcluster/pull/5805#discussion_r1038246108

Problem: hooks_last_fires keeps too much records for some hooks. Expiring them by time (> 1 year) is not efficient.
There should be some hard limit for the number of last fires we keep.
TBD: who is using those beyond 1000 records?

Dominant language
JavaScript
Stars
435
Forks
305
Avg merge
1d 9h
Merged PRs (30d)
93

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from taskcluster/taskcluster

All issues in taskcluster/taskcluster

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.