Refactor tests using `traits`

Open
#16 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
38/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
scala
Domain
testing

Research direction

No test files or entry points are named. Review the test suite, the utility functions proposed in #13, and Colin's suggestions in #14; refactor duplicated test setup using traits or functions, then verify the tests still pass and the suite is more concise.

Written by the indexing model from the issue text.

Description

@colindean made some good suggestions in #14 around refactoring tests using traits (See comment)
I tried to create a few new utility functions in #13, but I'd like to see if we can do something like Colin suggested, and make a pass through the tests and use any new traits or functions to make them more concise.
I suspect we can reduce the duplicate code in the tests, greatly reduce the test SLOC and make it easier to develop tests.

Dominant language
Scala
Stars
101
Forks
31
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from target/data-validator

All issues in target/data-validator

Similar issues

More Scala issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.