tarantool / tarantool/tt

Behavior related to user confirmations for operation varies for different commands

Open
#978 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

2sp code health teamE
Dominant language
Go
Stars
113
Forks
18
Avg merge
4d 11h
Merged PRs (30d)
23

Description

The mentioned differences can be divided into following topics:

  1. Confirmation target
    restart and kill commands ask for confirmation once and if confirmed apply the corresponding operation for all instances (when target implies multiple instances, like app-target in case of multi-instances application)
    clean asks confirmation for every single instance implied by target.
  2. Discard reply
    restart displays text • Restart is cancelled.
    kill produces no output, just finish the execution.
    clean displays • instance: cleaning... [ERR] canceled by user after every discarding.
  3. State validation
    clean only asks for confirmation if an instance is not running, otherwise just skips it with displaying instance `some_instance` must be stopped
    kill asks for confirmation regardless of instances states.

Consider using the single approach.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the implementations of the restart, kill, and clean commands, focusing on confirmation targets, cancellation output, and state validation. Done means these commands follow one consistent confirmation approach, including behavior for multiple instances and discarded replies.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.