Behavior related to user confirmations for operation varies for different commands
Open
Nobody has claimed this yet.
2sp
code health
teamE
- Dominant language
- Go
- Stars
- 113
- Forks
- 18
- Avg merge
- 4d 11h
- Merged PRs (30d)
- 23
Description
The mentioned differences can be divided into following topics:
- Confirmation target
restartandkillcommands ask for confirmation once and if confirmed apply the corresponding operation for all instances (when target implies multiple instances, like app-target in case of multi-instances application)
cleanasks confirmation for every single instance implied by target. - Discard reply
restartdisplays text• Restart is cancelled.
killproduces no output, just finish the execution.
cleandisplays• instance: cleaning... [ERR] canceled by userafter every discarding. - State validation
cleanonly asks for confirmation if an instance is not running, otherwise just skips it with displayinginstance `some_instance` must be stopped
killasks for confirmation regardless of instances states.
Consider using the single approach.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the implementations of the restart, kill, and clean commands, focusing on confirmation targets, cancellation output, and state validation. Done means these commands follow one consistent confirmation approach, including behavior for multiple instances and discarded replies.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100