tarantool / tarantool/tt

Different commands identify instances in a different ways

Open
#976 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

2sp code health teamE
Dominant language
Go
Stars
113
Forks
18
Avg merge
4d 11h
Merged PRs (30d)
23

Description

$ tt start replicaset_example
   • Starting an instance [replicaset_example:master]...
   • Starting an instance [replicaset_example:replica]...
$ tt start replicaset_example
   • The instance replicaset_example:replica (PID = 772688) is already running.
   • The instance replicaset_example:master (PID = 772687) is already running.
$ tt restart -y replicaset_example
   • The Instance replicaset_example:master (PID = 772687) has been terminated.
   • The Instance replicaset_example:replica (PID = 772688) has been terminated.
   • Starting an instance [replicaset_example:master]...
   • Starting an instance [replicaset_example:replica]...
$ tt logrotate replicaset_example
   • replicaset_example:master: logs has been rotated. PID: 777002.
   • replicaset_example:replica: logs has been rotated. PID: 777003.
$ tt clean replicaset_example
   • instance `master` must be stopped
   • instance `replica` must be stopped
$ tt stop replicaset_example
   • The Instance replicaset_example:master (PID = 777002) has been terminated.
   • The Instance replicaset_example:replica (PID = 777003) has been terminated.
$ tt clean -f replicaset_example
   • List of files to delete:

   • /var/log/tarantool/sys_env/replicaset_example/replica/tt.log
   • /var/lib/tarantool/sys_env/replicaset_example/replica/00000000000000000009.snap
   • /var/lib/tarantool/sys_env/replicaset_example/replica/00000000000000000009.xlog
   • replica: cleaning...	[OK]
   • List of files to delete:

   • /var/log/tarantool/sys_env/replicaset_example/master/tt.log
   • /var/lib/tarantool/sys_env/replicaset_example/master/00000000000000000000.snap
   • /var/lib/tarantool/sys_env/replicaset_example/master/00000000000000000000.xlog
   • /var/lib/tarantool/sys_env/replicaset_example/master/00000000000000000009.xlog
   • master: cleaning...	[OK] 
$ tt start replicaset_example
   • Starting an instance [replicaset_example:master]...
   • Starting an instance [replicaset_example:replica]...
$ tt kill -f replicaset_example
   • The instance replicaset_example:master (PID = 805812) has been killed.
   • The instance replicaset_example:replica (PID = 805813) has been killed.
$ tt kill -f replicaset_example
   • failed to kill the processes: can't get pid of running process: can't "stat" the PID file. Error: stat /var/run/tarantool/sys_env/replicaset_example/master/tt.pid: no such file or directory
   • failed to kill the processes: can't get pid of running process: can't "stat" the PID file. Error: stat /var/run/tarantool/sys_env/replicaset_example/replica/tt.pid: no such file or directory
$ tt logrotate replicaset_example
   ⨯ NOT RUNNING

In the above output various formats of instances can be found:

  • [app:inst] - start (when not running), restart (starting section)
  • app:inst - start, logrotate and kill (when running), stop, restart (stop section)
  • inst - clean (when running)
  • `inst` - clean (when not running)
  • no instances at all - logrotate and kill (when not running)

Instances should be identified uniformly, for example in [app:instance] format.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the CLI output handling for start, restart, logrotate, clean, stop, and kill, then compare how each command formats instance names in the examples. Standardize the displayed identifier to [app:instance] for every state and command, including error and cleanup output. Done means the listed commands consistently use that format.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.