tests: `test_t3_instance_names_no_config` disregards tmpdir path length
Open
Nobody has claimed this yet.
1sp
bug
teamE
- Dominant language
- Go
- Stars
- 113
- Forks
- 18
- Avg merge
- 4d 11h
- Merged PRs (30d)
- 23
Description
Now test with name test_t3_instance_names_no_config in test/integration/status/test_status.py disregards path of TMPDIR. The test cares about temporary directory that uses test but not about TMPDIR that can be too long.
See the error log that was in MacOS CI for example
Alerts for app:router:
• Error while connecting to instance app:router via socket /private/var/folders/7l/7gcbtl2n3gs11nqppj23z3t00000gp/T/tmpmjybm925/app/var/run/router/tarantool.control: failed to dial: dial unix /private/var/folders/7l/7gcbtl2n3gs11nqppj23z3t00000gp/T/tmpmjybm925/app/var/run/router/tarantool.control: connect: invalid argument
Alerts for app:master:
• Error while connecting to instance app:master via socket /private/var/folders/7l/7gcbtl2n3gs11nqppj23z3t00000gp/T/tmpmjybm925/app/var/run/master/tarantool.control: failed to dial: dial unix /private/var/folders/7l/7gcbtl2n3gs11nqppj23z3t00000gp/T/tmpmjybm925/app/var/run/master/tarantool.control: connect: invalid argument
Alerts for app:replica:
• Error while connecting to instance app:replica via socket /private/var/folders/7l/7gcbtl2n3gs11nqppj23z3t00000gp/T/tmpmjybm925/app/var/run/replica/tarantool.control: failed to dial: dial unix /private/var/folders/7l/7gcbtl2n3gs11nqppj23z3t00000gp/T/tmpmjybm925/app/var/run/replica/tarantool.control: connect: invalid argument
Alerts for app:stateboard:
• Error while connecting to instance app:stateboard via socket /private/var/folders/7l/7gcbtl2n3gs11nqppj23z3t00000gp/T/tmpmjybm925/app/var/run/stateboard/tarantool.control: failed to dial: dial unix /private/var/folders/7l/7gcbtl2n3gs11nqppj23z3t00000gp/T/tmpmjybm925/app/var/run/stateboard/tarantool.control: connect: invalid argument
When the expected log with right paths length should be look this way
Alerts for app:router:
• Error while connecting to instance app:router via socket /tmp/tmplbq48yhr/app/var/run/router/tarantool.control: failed to dial: dial unix /tmp/tmplbq48yhr/app/var/run/router/tarantool.control: connect: no such file or directory
Alerts for app:master:
• Error while connecting to instance app:master via socket /tmp/tmplbq48yhr/app/var/run/master/tarantool.control: failed to dial: dial unix /tmp/tmplbq48yhr/app/var/run/master/tarantool.control: connect: no such file or directory
Alerts for app:replica:
• Error while connecting to instance app:replica via socket /tmp/tmplbq48yhr/app/var/run/replica/tarantool.control: failed to dial: dial unix /tmp/tmplbq48yhr/app/var/run/replica/tarantool.control: connect: no such file or directory
Alerts for app:stateboard:
• Error while connecting to instance app:stateboard via socket /tmp/tmplbq48yhr/app/var/run/stateboard/tarantool.control: failed to dial: dial unix /tmp/tmplbq48yhr/app/var/run/stateboard/tarantool.control: connect: no such file or directory
Need to take into account the length of TMPDIR to prevent such unexpected errors.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with test/integration/status/test_status.py and inspect test_t3_instance_names_no_config, comparing the failing macOS paths with the expected /tmp paths shown in the issue. Run that test with a long TMPDIR; done means it accounts for TMPDIR length and avoids the unexpected Unix-socket error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100