tests: improve integration test
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 113
- Forks
- 18
- Avg merge
- 4d 11h
- Merged PRs (30d)
- 23
Description
Suggestion: move methods start_app() and stop_app() in common utilities for integration tests.
Also, it would be useful to use Python class with destructor __exit__(self, ...) to catch and stop running instance of testing application.
See also kill_remain_processes_wrapper() method at tt/test/integration/connect/test_connect.py it kills a lot of stuck watchdog processes:
/tmp/pytest-of-runner/pytest-0/tt_build0/tt --cfg /tmp/pytest-of-runner/pytest-0/cartridge_app0/tt.yaml start --watchdog cartridge_app:***. So stopping the app should down such processes as well, too.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with tt/test/integration/connect/test_connect.py, especially start_app(), stop_app(), and kill_remain_processes_wrapper(). Trace how integration tests launch and stop the testing application, then determine how the shared utility and cleanup lifecycle should work. Done means the common helpers handle application shutdown and no watchdog processes remain after tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100