tarantool / tarantool/tt

Improve `tt binaries list`

Open
#882 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

2sp bug teamE
Dominant language
Go
Stars
113
Forks
18
Avg merge
4d 11h
Merged PRs (30d)
23

Description

tt binaries list prints versions based on bin_dir only. It might be confusing while using it to print tarantool versions because include files might be missing.

I suggest to add an additional check for tarantool include files presence, and either don't print versions with missing files or print an error.

f.terekhin@f-terekhin tt % ls -al binaries
total 90480
drwxr-xr-x   6 f.terekhin  staff       192 Jun 20 18:35 .
drwxr-xr-x  41 f.terekhin  staff      1312 Jun 20 18:13 ..
-rw-r--r--   1 f.terekhin  staff         0 Jun 20 18:35 tarantool_2.3.0
lrwxr-xr-x   1 f.terekhin  staff         9 Jun 20 14:00 tt -> tt_v2.3.1
-rwxr-xr-x   1 f.terekhin  staff  23159088 Jun 20 13:40 tt_v2.3.0
-rwxr-xr-x   1 f.terekhin  staff  23159088 Jun 20 13:59 tt_v2.3.1
f.terekhin@f-terekhin tt % ls -al include/include 
total 0
drwxr-xr-x   5 f.terekhin  staff  160 May 29 12:47 .
drwxr-x---   3 f.terekhin  staff   96 Mar 13 14:29 ..
f.terekhin@f-terekhin tt % ./tt binaries list    
List of installed binaries:
   • tt:                      
	2.3.1 [active]
	2.3.0
   • tarantool:               
	2.3.0

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the tt binaries list command and trace how entries from bin_dir become displayed versions. Check how Tarantool include files are represented, then define completion as avoiding misleading versions with missing files or reporting a clear error. Add coverage for the shown empty-include-files case if the command's tests are found.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.