tarantool / tarantool/tt

libcluster: make a specific error on missing data

Open
#789 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
113
Forks
18
Avg merge
4d 11h
Merged PRs (30d)
23

Description

Now we need to compare strings to find out that a collector does not found data in a prefix:

https://github.com/tarantool/go-discovery/blob/fc4ddcb2f8a3929d8bc7f7b611467b7b4183ebb8/discoverer/etcd.go#L86-L89

This is not a good approach, we need to make a separate error type/constant for such cases.

And we need to fix the message:
https://github.com/tarantool/go-discovery/pull/23#discussion_r1504359449

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read discoverer/etcd.go around lines 86-89 to understand how missing data is currently identified, then review the linked pull-request discussion for the message concern. Confirm the separate error type or constant covers the missing-prefix case and that its message matches the intended wording.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, distributed-systems
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.