build shouldn't patch submodules
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 113
- Forks
- 18
- Avg merge
- 4d 11h
- Merged PRs (30d)
- 23
Description
This is a bad practice.
In the way we have to revert all patches in clean target, and we have to be able to revert them after git pull origin master.
So, the best way is patching the copy of submodules inside builddir (that will be removed/cleanded by clean target)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the build and clean targets, then trace where patches are applied to submodules. Done means patches are applied only to submodule copies inside builddir, and clean removes those copies without requiring changes to be reverted after git pull origin master.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100