tarantool / tarantool/tarantool

Debugger followup: fix breakpoint for relative path

Open
#8,346 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
3.7k
Forks
419
Avg merge
1d 23h
Merged PRs (30d)
88

Description

In debugger step 2 brand new breakpoints there is an issue of setting bp for the outer and current dirs (i.e. ../ and ./). The breakpoint is set, but during runtime the hook isn't activated. Consider the example:

luadebug.lua: Loaded for 2.11.0-entrypoint-999-g0241645fd
break via dbg() => ./main.lua:8 in chunk at ./main.lua:0
   5   
   6   dbg()
   7   
   8=> hello_1()
   9   hello_2()
  10   
  11   local compat = require('tarantool').compat
luadebug.lua> b ../build/main.lua:11
Added breakpoint ../build/main.lua:11.
   8   hello_1()
   9   hello_2()
  10   
  11=>●local compat = require('tarantool').compat
  12   
  13   print(compat.dump())
luadebug.lua> c
hello 1!
hello 2!
require('tarantool').compat({
    yaml_pretty_multiline            = 'default',
    json_escape_forward_slash        = 'default',
    fiber_channel_close_mode         = 'default',
    box_cfg_replication_sync_timeout = 'default',
})

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the debugger step 2 changes referenced in pull request 7790 and reproduce the example in luadebug.lua using breakpoints for ./main.lua and ../build/main.lua. Trace why the runtime hook is not activated for these relative paths; done means both outer- and current-directory breakpoints activate during execution.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.