tarantool / tarantool/tarantool
Renew mvcc monitoring metrics
Open
Nobody has claimed this yet.
blocked
feature
mvcc
- Dominant language
- Lua
- Stars
- 3.7k
- Forks
- 419
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 88
Description
In #8122 one of mvcc objects - memtx_tx_conflict - was removed as a class. However, it was not removed from mvcc memory monitoring by several reasons:
- It's a breaking change. At least metrics module relies on existence of this metric. Fix of that module and deprecation policy is needed.
- It is expected that some other objects can be removed in further refactoring and it is reasonable to postpone metrics renewal to that moment.
- It's a bit complicated and requires simultaneous update of (at least) metrics module.
We should return to this issues once mvcc refactoring is completed.
After #8654 the same story happened to tx_conflict_tracker.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the completed MVCC refactoring and the metrics module, including handling for memtx_tx_conflict and tx_conflict_tracker. Coordinate the metrics update with the deprecation policy; done means monitoring no longer depends on removed MVCC objects and reflects the final set of objects.
Written by the indexing model from the issue text.
Assessment
- Domain
- databases, observability
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100