tarantool / tarantool/tarantool

Provide careful validation for box.schema.space.create() arguments

Open
#5,636 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature good first issue verbosity
Dominant language
Lua
Stars
3.7k
Forks
419
Avg merge
1d 23h
Merged PRs (30d)
88

Description

Now only memtx spaces can be temporary. Support of vinyl temporary spaces should be added in scope of #1785. However, now it is possible specify vinyl engine alongside with 'temporary' option:

box.schema.space.create('temp', {temporary=true}, {engine = 'vinyl'})
---
- engine: memtx
...

As one can see, vinyl engine is ignored and created space anyway uses memtx. I suggest to raise an error in this case in order to avoid misunderstanding.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the box.schema.space.create() entry point and reproduce the Lua example with temporary=true and engine='vinyl'. Trace how those arguments are validated and confirm the completed behavior rejects the incompatible combination instead of silently creating a memtx space.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.