tarantool / tarantool/tarantool
popen: implement thorough testing of popen Lua module
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 3.7k
- Forks
- 419
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 88
Description
Tarantool version: 2.5.0-2-g098324556.
Many different aspects of the module behaviour are not tested at all. Say, we don't check that the engine actually closes STD{IN,OUT,ERR}_FILENO file descriptors when a user asked for this.
There is the rought plan:
And a couple of FIXME comments:
(But the latter should be fixed in #4913.)
See also #4921.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with test/app-tap/popen.test.lua, especially the rough plan at lines 512-603 and the FIXME comments at lines 319-324 and 411-412. Review the existing popen tests and related issue #4921; account for #4913 before addressing the latter FIXME. Done means the planned module behaviors are covered, including closing STDIN, STDOUT, and STDERR descriptors when requested.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100