tarantool / tarantool/tarantool

config: alert when giving execute access w/o `lua_call`

Open
#12,830 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

config feature
Dominant language
Lua
Stars
3.7k
Forks
419
Avg merge
1d 23h
Merged PRs (30d)
88

Description

Currently, execute w/o specifying lua_call in credentials is really permissive. For instance,

credentials:
  users:
    alice:
      privileges:
        - permissions: [execute]
          universe: true

lets alice call all global functions which includes box.session.su().

It is worth introducing a warning that notifies a user that execute w/o lua_call can be dangerous since it can be non-trivial (w/o reading the docs, for sure).

I find the following way to disable a warning the most straightforward.

credentials:
  users:
    alice:
      privileges:
        - permissions: [execute]
          lua_call: *

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the configuration and privilege-handling code for YAML credentials, using the shown execute-only example to reproduce the permissive access. Trace where execute privileges without lua_call are accepted, then add a warning and verify that specifying lua_call: '*' suppresses it.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
authorization, security
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.