Unnecessary session creation for connection that is not for queue
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 244
- Forks
- 56
- PR merge metrics
- No merged PRs in 30d
Description
The number of requests has increased significantly аfter installation of queue module.
I use tarantool for data cache and when the client disconnects, the queue creates a new session and immediately delete it. It is not necessary.
I researched this and got that: the queue have event connection.on_disconnect. It calls identify, which select session by connection id. It insert id in queue_session_ids and return session, which are deleted immediately on disconnect.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in queue/abstract/queue_session.lua at identify, queue_session_ids, and the on_disconnect handler. Trace how a disconnected connection is identified and whether a session is inserted before deletion. Done means non-queue connections no longer create and immediately remove sessions, while queue-session cleanup still works.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100