`on_schema_reload` trigger of `net.box` connections behaviour update
Nobody has claimed this yet.
- Dominant language
- CSS
- Stars
- 15
- Forks
- 49
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 3
Description
Related dev. issue(s): https://github.com/tarantool/tarantool/issues/9679
Product: Tarantool
Since: 3.1
Root document: https://www.tarantool.io/en/doc/latest/reference/reference_lua/net_box/#lua-function.conn.on_schema_reload
SME: @ CuriousGeorgiy
Details
When an error is thrown from the on_schema_reload trigger, it now behaves
the same way as the on_disconnect trigger ^1:
If the trigger function causes an error, the error is logged but
otherwise is ignored.
Requested by @ CuriousGeorgiy in https://github.com/tarantool/tarantool/commit/bbd8b684251c3bc1f092a3cc2570c6d12f117418.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the net.box conn.on_schema_reload documentation named in the issue and compare its trigger-error behavior with the on_disconnect documentation. Update the on_schema_reload description to state that errors are logged and ignored, then verify the wording matches the current behavior and linked development issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100