Possible performance improvement
Open
Nobody has claimed this yet.
performance
- Dominant language
- Lua
- Stars
- 43
- Forks
- 17
- Avg merge
- 28m
- Merged PRs (30d)
- 2
Description
If run the benchmark from the repository with enabled jit.dump it may be observed that there are many trace abortions due to FNEW bytecode:
Rewriting this functions as locals to avoid their generation at each call may improve the performance.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with test/performance/perf_test.lua and run the benchmark with jit.dump enabled. Inspect the function sites in crud/select/executor.lua around line 143 and crud/compare/comparators.lua around line 89, then compare the trace-abortion output and benchmark performance after the functions are made locals.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- performance
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100