Support field id in select/pairs conditions
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 43
- Forks
- 17
- Avg merge
- 28m
- Merged PRs (30d)
- 2
Description
Follows #350
Update conditions support field number ids (moreover, due to compatibility with older Tarantool, all non-number identificators are converted to number ones, see https://github.com/tarantool/crud/blob/3f2db887d13c00a0f1f402f59fba795fb39e5703/crud/common/utils.lua#L591-L618). Select/pairs are not, see #241 example.
I don't remember hearing any user requests about field id support, so I'll put a question label here. On the other hand, I don't see any reasons against adding this (like there were for space id in https://github.com/tarantool/crud/issues/255) since we expect space schema to be the same everywhere.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the referenced conversion logic in crud/common/utils.lua and compare how select and pairs conditions handle field identifiers, using the #241 example for expected behavior. Confirm the intended compatibility behavior for numeric and non-numeric field IDs, then add coverage showing that select and pairs accept field number IDs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- database
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100