taozhi8833998 / taozhi8833998/node-sql-parser

Please include SQL comments in ast object

Open
#525 3 comments 11 reactions 1 assignee View on GitHub

@taozhi8833998 is already working on this.

Since Dec 22, 2020.

Dominant language
PEG.js
Stars
1k
Forks
244
PR merge metrics
No merged PRs in 30d

Description

As it is now, some proprietary SQL features are not supported, like FOR XML PATH() on SQL Server for example.

As long as it would be nice to eventually have such language support, if the ast object was at least keeping the original SQL comments, it would be possible to us to pre-parse the sql text, transform unknown tags for the parser into comments, and later when rebuilding the sql, either revert back those comments to normal tags or even do custom replacements based on some arbitrary logic.

This would make a lot easier to live with parser limitations.

Thanks!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.