taozhi8833998 / taozhi8833998/node-sql-parser

Trino sql parser no longer reports * errors correctly

Open
#2,119 0 comments 0 reactions 1 assignee View on GitHub

@taozhi8833998 is already working on this.

Since Sep 16, 2024.

Dominant language
PEG.js
Stars
1k
Forks
244
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
At some point, the parser used to show an error on the * for syntax in this query:

SELECT *
FROM someTable
WHERE u BETWEEN * * * * * * * * * t('today')
LIMIT 10

It now instead reports t as the error.

Database Engine
which database engine does your SQL running on? such as MySQL, PostgreSQL.

Trino

To Reproduce
-the SQL that be parsed
-the node-sql-parser version
-the node version

Using

SELECT *
FROM someTable
WHERE u BETWEEN * * * * * * * * * t('today')
LIMIT 10

Node version: v18.20.4
node-sql-version: v5.3.2

Notice the error is not reported on the * but rather the t.

Expected behavior
A clear and concise description of what you expected to happen.

Syntax error on the first *.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.