tailscale / tailscale/tailscale

Tagged device UI still shows the user who created the node

Open
#4,626 13 comments 0 reactions 0 assignees View on GitHub
bug L4 Most users P1 Nuisance T2 Visual Polish
Dominant language
Go
Stars
36.5k
Forks
3.2k
Avg merge
1d 23h
Merged PRs (30d)
132

Description

### What is the issue?

Here is the configuration:
![image](https://user-images.githubusercontent.com/1356959/167058753-8a07cc5f-99bb-4867-8471-6d93121c5b78.png)
The two `desktop-` machines belong to the user `user@company.com`.

When RDP into `my-server`, in the Taskbar we see this:
![image](https://user-images.githubusercontent.com/1356959/167058647-4f9fb6f0-7c44-440b-bf6d-aef000454875.png)

This is the ACL I'm using:
```
// Example/default ACLs for unrestricted connections.
{
// Declare static groups of users beyond those in the identity service.
"groups": {
"group:dc-admins": [ "user@company.com" ],
},
// Tags
"tagOwners": {
"tag:client-vm": ["user@company.com"],
},
// Access control lists.
"acls": [
// All employees can access their own devices (i.e. mobile phones)
{ "action": "accept", "src": ["autogroup:members"], "dst": ["autogroup:self:*"] },

// DC-Admins can access the client VMs
{ "action": "accept", "src": ["group:dc-admins"], "dst": ["tag:client-vm:*"] },
]
}
```

My expectation is that the server is tagged, ACLs are deny-by-default, and therefore I should need an ACL line to give access from `client-vm` back to the users' machines. But the machine is inheriting the users' permissions from `user@company.com` and hence able to see their devices included in the group `autogroup:self`.

I consider this to be quite a serious security issue as the server could be used as a bastion to access i.e. the users' personal phones or other devices on a Tailscale network that they may not have realised were included in the ACL.

### Steps to reproduce

_No response_

### Are there any recent changes that introduced the issue?

_No response_

### OS

Windows, Other

### OS version

Pro, Server Standard 2022

### Tailscale version

1.24.2

### Bug report

BUG-9e73d5909f38f1088789709ad7287d617350da7421db67d847081940bad86f99-20220506024959Z-b90acd5cffd19254

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.