tailscale / tailscale/tailscale

tailcfg: de-pointer a bunch of fields now that we have omitzero

Open
#17,978 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
36.5k
Forks
3.2k
Avg merge
2d 3h
Merged PRs (30d)
123

Description

tailcfg.go is full of pointers to things just for JSON `omitempty` reasons. Nowadays we would've dropped the pointer and used `omitzero` instead.

We should do a pass over tailcfg and the caller code and see if we can modernize them.

We'll have to be careful on the control server side to not break old clients (or the server handling requests from old clients), but maybe that's easier than I'm fearing.

/cc @dsnet @tailscale/client-core

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.