tailscale / tailscale/tailscale

cmd/viewer: generate method wrappers

Open
#13,191 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
36.5k
Forks
3.2k
Avg merge
2d 3h
Merged PRs (30d)
123

Description

The `tailscale.com/cmd/viewer` utility needs to be updated to generate methods that wrap the underlying type's methods with value receivers. The generated methods should transform the return parameters of the underlying methods to make them read-only. Additionally, the utility should generate `{Type}ViewOf` functions to be used as [`MakeViewFn`](https://github.com/tailscale/tailscale/blob/20562a4fb9c2af417c44b3ab63a826d9d0f6b6b2/cmd/viewer/viewer.go#L80)s by the `cmd/viewer` itself.

From https://github.com/tailscale/tailscale/pull/12830#discussion_r1722595393

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.