tailscale / tailscale/tailscale-rs
ts_tunnel: don't respond to keepalives with more keepalives
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 1.2k
- Forks
- 61
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 22
Description
Currently, the receive path schedules the transmission of a keepalive for any packet that successfully decrypts, including keepalives sent by the peer. This means that keepalives will keep ping-ponging for the entire duration of the session, until the check for expired sessions in send_keepalive declines to rotate the session if there's no other traffic.
Instead, only schedule a keepalive transmission if a non-keepalive packet was received.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the ts_tunnel receive path and the send_keepalive entry point, then trace how successfully decrypted packets are identified as keepalives. The change is complete when receiving a keepalive no longer schedules another keepalive, while receiving a non-keepalive packet still does.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100