[Type 3] Don't let signin requests be sent if they use http when server expects https

Open
#1,091 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
38/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
api, authentication

Research direction

Start by tracing the sign-in request and the unauthenticated endpoint described in the issue. Verify how the client handles an HTTP URL when the server requires HTTPS, then ensure completion means HTTPS is detected and used before the initiating request is sent, with HTTP refused in that case.

Written by the indexing model from the issue text.

Description

enhancement good first issue

We very often see users getting an inexplicable error because they entered a http url and the server expected https: 405 Method Not Allowed (https://tableau.github.io/server-client-python/docs/sign-in-out#405000-method-not-allowed-response)

Instead, the client library should ping the unauthenticated endpoint and check if ssl is enabled first, and then switch to ssl if supported before sending the initiating request. Don’t even allow someone to send http if https is enabled. (I think Tableau Desktop already does that)

Dominant language
Python
Stars
716
Forks
446
Avg merge
8d 8h
Merged PRs (30d)
2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from tableau/server-client-python

All issues in tableau/server-client-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.