xfile - Issue opening a .twbx containing custom geocoding
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 55/100
Research direction
Start at find_file_in_zip() and inspect how candidate_files handles .twb and .tds entries in a .twbx containing custom geocoding. Reproduce with a workbook archive containing both file types if possible. Done means .tds files are not evaluated as workbooks and the .twbx opens without TableauInvalidFileException.
Written by the indexing model from the issue text.
Description
Hello,
I was trying to open a 9.3 workbook with custom geocoding attached. find_file_in_zip() evaluates .tds files as well as .twb files when opening a .twbx. A .twbx can contain .tds files if it contains custom geocoding.
I'm not quite sure what determines the order of the filenames in candidate_files, but if a .tds happens to end up before a .tdw in the list, the .tds will be evaluated first as a workbook. This raises the TableauInvalidFileException: filename is not a valid 'workbook' file.
I cannot share the workbook (it contains private data), I can share some screenshots of its contents:
A suggested fix for this would be to only check for .twb's if the file is a .twb/.twbx.
Cheers,
Marco
- Dominant language
- Python
- Stars
- 363
- Forks
- 183
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from tableau/document-api-python
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
tableau/document-api-python#270 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
tableau/document-api-python#260 ·
-
docs
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
tableau/document-api-python#258 ·
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
tableau/document-api-python#251 · 2 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
tableau/document-api-python#250 · 2 comments ·
All issues in tableau/document-api-python
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
🐛 Bug 🔔 Pending processing
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
jumpserver/jumpserver#17584 ·