syntaxfm / syntaxfm/website

Guest photos missing for guests without GitHub — add X/Twitter photo fallback

Open Beginner friendly
#2,182 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Svelte
Stars
1.2k
Forks
515
Avg merge
23h
Merged PRs (30d)
13

Description

The guests page sources all photos from https://github.com/{guest.github}.png. Guests without a GitHub handle get a broken/default image.

12 guests currently missing photos

Guest Twitter fallback available
Dr. Courtney Tolinski drtolinski
Varun Mohan _mohansolo
Taylor Desseyn tdesseyn
Topher Martini tophermartini
Hans Skillrud DeepSpaceHans
Donata Skillrud DonataSkillrud
Syed Balkhi syedbalkhi
Tim Leland TimLeland
Connor Finlayson FinlaysonConnor
Harry Dry harrydry
Loïc Houssier ❌ no twitter either
Anna Poblets ❌ no twitter either

Proposed fix

Fall back to https://unavatar.io/twitter/{guest.twitter} when guest.github is null. Loïc Houssier and Anna Poblets would still need a generic placeholder.

Two small changes needed:

  • Add twitter to the guest select in src/routes/(site)/guests/+page.server.ts
  • Update the <img src> logic in src/routes/(site)/guests/+page.svelte to use the fallback

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the guest query in src/routes/(site)/guests/+page.server.ts, then inspect the image source logic in src/routes/(site)/guests/+page.svelte. Add the Twitter field to the selected guest data and use the stated Twitter fallback when GitHub is unavailable. Verify that guests with neither handle receive a generic placeholder and that the listed guests no longer show broken images.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, web-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.