swiftwasm / swiftwasm/JavaScriptKit

BridgeJS: Add diagnostics for unsupported `from: .global` / `from: .module(...)` parameters for imported symbols

Open
#793 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
986
Forks
76
Avg merge
21h 11m
Merged PRs (30d)
4

Description

BridgeJS only supports the .from in top-level decls for @JSClass, @JSFunction and @JSGetter. In other places (eg: class members) the specified JSImportFrom is essentially ignored.

we should add diagnostics instead of ignoring invalid from parameters.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing BridgeJS handling of @JSClass, @JSFunction, and @JSGetter declarations and their imported symbols. Check how JSImportFrom is processed for top-level declarations and class members; done means unsupported .global and .module(...) parameters produce diagnostics instead of being ignored.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, swift
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.