swiftlang / swiftlang/swift

Use generated `TokenSpecSet`s in ASTGen

Open
#68,356 3 comments 0 reactions 1 assignee View on GitHub

@rintaro is already working on this.

Since Oct 2, 2023.

ASTGen compiler
Dominant language
Swift
Stars
70.4k
Forks
10.8k
PR metrics pending

Description

https://github.com/apple/swift/pull/67111/files#diff-e513d3adfa93904a74cb6d3e8ac3ae4701ed41ccaa0461428708231d8aee5b63R469-R482 basically re-implements ImportDeclSyntax.ImportKindSpecifierOptions (https://github.com/apple/swift-syntax/blob/452e07df5459309a10766e4a7f9f67f74bd23763/Sources/SwiftParser/generated/Parser%2BTokenSpecSet.swift#L1663-L1672).

ASTGen should use ImportDeclSyntax.ImportKindSpecifierOptions. For that, we need to

  • Decide whether to move ImportDeclSyntax.ImportKindSpecifierOptions to SwiftSyntax or whether it should stay in SwiftParser
  • Check if we need to add a new initializer to the generated TokenSpecSet that ASTGen can use.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.