swiftlang / swiftlang/swift-java

@JavaClass and inherited methods needs a redesign

Open
#441 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature:wrap-java
Dominant language
Swift
Stars
1.2k
Forks
123
Avg merge
1d 7h
Merged PRs (30d)
16

Description

Currently @JavaClass("JavaStorageItem", implements: SomeSuperType.self) doesn't actually give instances of JavaStorageItem methods from SomeSuperType which is very hard to work with.

Developers need to know they have to as(SomeSuperType.self) though that's very counterintuitive.

Instead, when generating an open class interface, we need to make a protocol, put methods on it, and then anyone who implements: needs to conform their type to the SomeSuperTypeOperationsProtocol or something like that.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the @JavaClass handling and the generated open class interface path; the issue names no files or tests. Done means an implementing type exposes inherited SomeSuperType methods directly without requiring as(SomeSuperType.self), with protocol conformance generated for the relevant operations.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, swift
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.