swiftlang / swiftlang/swift-java
jextract must handle "sibling" types while extracting
Open
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 1.2k
- Forks
- 123
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 16
Description
For example file 1:
struct Hello {}
file 2:
struct HelloAgain {
init(hello: Hello) {}
}
if we visit them in the order Hello, then HelloAgain things work fine.
If we happen to visit them HelloAgain first, then we'll reject importing the HelloAgain type because:
[info][JExtractSwift/Swift2JavaVisitor.swift:219](visit(_:)) Unable to import initializer due to unknown(IdentifierTypeSyntax
╰─name: identifier("Hello"))
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at Swift2JavaVisitor.swift:219 and inspect how type references are resolved during visitation. Reproduce the examples with Hello visited before and after HelloAgain; done means both visitation orders successfully import HelloAgain and its initializer parameter.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100