swiftlang / swiftlang/swift-installer-scripts
Toolchain installers versions conflict between local builds and CI main builds
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 82
- Forks
- 64
- Avg merge
- 3d 4h
- Merged PRs (30d)
- 11
Description
From FireGiant:
In SemVer, the second bundle, with a version of 0.0.0, is considered a higher version than the first bundle with a version of 0.0.0-20240506.2. The latter version is considered a prerelease due to the -. A prerelease is lower in version sort order than an equivalent version (0.0.0) without the -. If you're expecting a newer local build to be a "later" version, this SemVer rule will
Both bundles install packages into the same 0.0.0 root, so they overwrite. platforms/Windows/SideBySideUpgradeStrategy.props uses the Major.Minor version to define the upgrade version ranges so 0.0.0 can't coexist. If you want that ability, you could define in SideBySideUpgradeStrategy.props different version ranges for "semi-official" builds (e.g., 0.1 or 1.0 as a version that won't overlap with official Swift builds).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading platforms/Windows/SideBySideUpgradeStrategy.props and compare the version ranges used for local and CI main builds. Confirm how the 0.0.0 and 0.0.0-20240506.2 versions are ordered and installed; done means the builds no longer overwrite one another and can coexist.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system, release
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100