swiftlang / swiftlang/swift-corelibs-libdispatch
[SR-2202] asyncAfter(deadline: DispatchTime, ...) has an erroneous parameter label
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 2.6k
- Forks
- 496
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 3
Description
| Previous ID | SR-2202 |
| Radar | None |
| Original Reporter | @glessard |
| Type | Bug |
Environment
Swift Development Snapshot 2016-07-25a
Additional Detail from JIRA
| Votes | 0 |
| Component/s | libdispatch |
| Labels | Bug |
| Assignee | None |
| Priority | Medium |
md5: 395e15545be80824dafa50c11102d386
Issue Description:
A deadline is the latest possible moment in time at which work can have been completed. (dictionaries concur)
This timestamp is the earliest moment in time at which work can be initiated.
It's completely backwards! I'm puzzled how this could have happened.
This being said, with the new function name, it's not clear that a parameter label is needed at all. The type of the parameter is a timestamp (in both the DispatchTime or the DispatchWallTime versions), so that "dispatch after a timestamp" is completely understandable.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the asyncAfter(deadline: DispatchTime, ...) API entry point and compare it with the DispatchWallTime variant mentioned in the issue. Determine whether the parameter label should be corrected or removed, then confirm that the resulting API matches the stated timestamp semantics.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100