swiftlang / swiftlang/swift-corelibs-libdispatch

[SR-7724] libdispatch gets built twice on Linux when sourcekit is enabled

Open
#654 5 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

bug libdispatch
Dominant language
C
Stars
2.6k
Forks
496
Avg merge
2d 6h
Merged PRs (30d)
3

Description

Previous ID SR-7724
Radar None
Original Reporter @kevints
Type Bug
Status In Progress
Resolution
Additional Detail from JIRA
Votes 0
Component/s libdispatch, Source Tooling
Labels Bug
Assignee @kevints
Priority Medium

md5: be0f60374adcf80ee5d8090c026d8f95

Issue Description:

This appears to be a bug in the build system, on Linux sourcekit will cause libdispatch to be built a second time, using the CMake ExternalProject feature.

This unfortunately doesn't preserve all of the options that were passed to build-script (which builds libdispatch separately here, but a seemingly-arbitrary subset of them.

We should ideally refactor the build so that dispatch is only built once, and with the same collection of arguments.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.