swiftlang / swiftlang/swift-corelibs-libdispatch
[SR-9368] libdispatch_static unit tests are disabled
Open
Nobody has claimed this yet.
bug
libdispatch
- Dominant language
- C
- Stars
- 2.6k
- Forks
- 496
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 3
Description
| Previous ID | SR-9368 |
| Radar | None |
| Original Reporter | @kevints |
| Type | Bug |
Additional Detail from JIRA
| Votes | 0 |
| Component/s | libdispatch |
| Labels | Bug |
| Assignee | None |
| Priority | Medium |
md5: 30b402df2ea7747770589550544f234d
relates to:
- SR-10625 tests for -static-*
- SR-7039 can't use -static-stdlib (or -static-executable) with any Dispatch using app
Issue Description:
https://github.com/apple/swift/pull/20793 introduced a libdispatch_static product to the build script but doesn't run its unit tests. To ensure code quality we should make sure the unit tests pass on this path as well.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the build-script change in pull request 20793 and how the libdispatch_static product is defined. Find the existing libdispatch unit-test entry point, enable or exercise it for the static product, and confirm that the unit tests pass on this path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- build-system, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100