swiftlang / swiftlang/github-workflows
Shell license checks should not check the shebang (`#!`)
Open
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 115
- Forks
- 57
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 3
Description
The license header GHA fails, unnecessarily, with the following:
❯ ../github-workflows/.github/workflows/scripts/check-license-header.sh
--- Expected header
+++ .devcontainer/init.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh -x
##===----------------------------------------------------------------------===##
##
## This source file is part of the Swift open source project
It is wrong, and too restrictive, to have the "shebang" cause a license check violation.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with .github/workflows/scripts/check-license-header.sh and reproduce the failure against .devcontainer/init.sh. Confirm that the license check no longer treats the shebang as a header violation while still checking the remaining license header.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, shell
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100