swift-server / swift-server/async-http-client
Consider making handshake errors fatal
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 1.1k
- Forks
- 156
- PR merge metrics
- No merged PRs in 30d
Description
Related to #743 - there are certain errors that it doesn't make sense attempting to retry. I've hit this issue several times in Vapor where a certificate handshake error is retried until the timeout, which then eventually fails. A cert error isn't recoverable and will fail on subsequent requests so this one should probably error straight away
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the retry behavior described in related issue #743 and locate the handshake error handling path in async-http-client. The work is done when unrecoverable certificate handshake errors fail immediately instead of being retried until timeout, with coverage for that behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100