swift-server / swift-server/async-http-client

Should swift-configuration be included as a dependency with no traits enabled

Open
#898 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
1.1k
Forks
156
PR merge metrics
No merged PRs in 30d

Description

swift-configuration has a default trait list of ["JSON"]. async-http-client includes swift-configuration with this default. Now any package dependent on async-http-client now includes the JSON trait, even if they don't want it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by locating async-http-client's Swift package dependency declaration for swift-configuration and review how SwiftPM default traits are configured. Done means the dependency no longer enables the JSON trait transitively, with package validation or tests confirming the resulting trait behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.