swift-server / swift-server/async-http-client
context.fireUserInboundEventTriggered called from inside triggerUserOutboundEvent
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 1.1k
- Forks
- 156
- PR merge metrics
- No merged PRs in 30d
Description
I just happened to notice that both HTTP1ClientChannelHandler and HTTP2ClientRequestHandler are both calling context.fireUserInboundEventTriggered from inside their implementations of triggerUserOutboundEvent. If this is intentional, adding a comment explaining why an outbound event would suddenly turn into an inbound event would probably be good.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the implementations of triggerUserOutboundEvent in HTTP1ClientChannelHandler and HTTP2ClientRequestHandler, focusing on their calls to context.fireUserInboundEventTriggered. Determine whether the direction change is intentional; done means the behavior is explained with comments in both implementations if it is.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- networking
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100