swift-server / swift-server/async-http-client

[HTTP2] Send GOAWAY frame before shutdown

Open
#507 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
1.1k
Forks
156
PR merge metrics
No merged PRs in 30d

Description

Currently we don't send a GOAWAY frame before closing the connection. But the RFC states:

Endpoints SHOULD always send a GOAWAY frame before closing a
connection so that the remote peer can know whether a stream has been
partially processed or not.

https://datatracker.ietf.org/doc/html/rfc7540#section-6.8

We should send a GOAWAY frame before connection close.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the HTTP/2 connection shutdown path in async-http-client and review RFC 7540 section 6.8 linked in the issue. Done means the client sends a GOAWAY frame before closing the connection, allowing the peer to determine whether streams were partially processed.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
networking
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.