swift-server / swift-server/async-http-client
`maximumConcurrentConnections` should not be part of `HTTP1Connections`
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 1.1k
- Forks
- 156
- PR merge metrics
- No merged PRs in 30d
Description
During refactoring in https://github.com/swift-server/async-http-client/pull/482 we noticed that HTTP1Connections should not know about maximumConcurrentConnections. We should move the state to the HTTP1StateMachine. After that we can also continue the work to make HTTP2StateMachine.http1Connections and HTTP1StateMachine.http2Connections non-optional.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how HTTP1Connections currently stores and uses maximumConcurrentConnections, then read the HTTP1StateMachine and HTTP2StateMachine references mentioned in the issue. Move that state to HTTP1StateMachine and continue toward making the HTTP2StateMachine.http1Connections and HTTP1StateMachine.http2Connections references non-optional; done means the refactor is consistent and the existing test suite passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100