swift-server / swift-server/async-http-client
[HTTPConnectionPool] Performance: Cancel timer outside of stateLock
Open
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 1.1k
- Forks
- 156
- PR merge metrics
- No merged PRs in 30d
Description
Currently connection idle and request timers are cancelled inside the HTTPConnectionPool stateLock. We should move the cancellation (and only the cancellation) outside.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at HTTPConnectionPool and trace where connection-idle and request timers are cancelled while stateLock is held. Move only the cancellation outside the lock, preserving the surrounding state updates, and verify that the existing HTTP client behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- networking, performance
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100