swift-server / swift-server/async-http-client
make HTTPClient.Configuration.tlsConfiguration non-nil
Open
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 1.1k
- Forks
- 156
- PR merge metrics
- No merged PRs in 30d
Description
HTTPClient always has a TLS configuration so we don't need to have tlsConfiguration be optional. It should be defaulted to the default config and not nil. The code always uses configuration.tlsConfiguration ?? TLSConfiguration.forClient() which isn't right.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating HTTPClient.Configuration and searching for tlsConfiguration and the TLSConfiguration.forClient() fallback. Done means the configuration provides a non-nil default TLS configuration and callers no longer need the optional fallback.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100